Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

edit option from file viewer #1714

Open
kxkv opened this issue Apr 8, 2018 · 8 comments
Open

edit option from file viewer #1714

kxkv opened this issue Apr 8, 2018 · 8 comments

Comments

@kxkv
Copy link

kxkv commented Apr 8, 2018

FastHub Version: 4.6.7
Android Version: 8.1.0 (SDK: 27)
Device Information:

  • Manufacturer: HMD Global
  • Brand: Nokia
  • Model: Nokia 8

i really want and need to option to edit the file from the file viewer page. right now you have to go to the overview page, and then click edit for a given file. there should be an edit button or option directly from the screen where you view a file.

i am using this app for viewing and editing todo lists (.md files). having to navigate back to the overview page for editing a file is annoying.

however, thanks for a great app!

@cozyplanes
Copy link
Contributor

PR welcome

@k0shk0sh
Copy link
Owner

k0shk0sh commented Apr 9, 2018

I didn't get u, clicking on the menu button on the file actually list down edit functionality, so where is the issue in here?

@k0shk0sh
Copy link
Owner

k0shk0sh commented Apr 9, 2018

@yakov116
Copy link
Collaborator

yakov116 commented Apr 9, 2018

@k0shk0sh open the file. over there he would like an option

@kxkv
Copy link
Author

kxkv commented Apr 9, 2018

@k0shk0sh (@yakov116)

yes. i would like an edit button when the file is opened. here:
image

@k0shk0sh
Copy link
Owner

k0shk0sh commented Apr 9, 2018

in this case i'll end up making two extra APIs ;) one to see you are owner and one to check if you are collaborator. I think the owner part is not needed if i have the username of the repo which usually i do, but another API is needed. I think this is a good feature to have, so i'm gonna accept it however can't promise anytime soon.

@kxkv
Copy link
Author

kxkv commented Apr 9, 2018

@k0shk0sh
i understand. well, thanks a lot for accepting this as a feature. all the best for the future development of this app.

by the way, "Status: Completed" - wrong status?

@yakov116
Copy link
Collaborator

yakov116 commented Apr 9, 2018

@klevstul maybe he did it already :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants