Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Preferred Language is not applied when i open fasthub via github.com url #1906

Open
Alex4386 opened this issue Jun 27, 2018 · 10 comments
Open

Comments

@Alex4386
Copy link
Contributor

FastHub Version: 4.6.7
Android Version: 7.0 (SDK: 24)
Device Information:

  • Manufacturer: LGE
  • Brand: lge
  • Model: LG G4

Just as described in the title.

How to reproduce

  1. Set your fasthub language which is not device language.
  2. Open FastHub via chrome (e.g. opening github repository)
  3. FastHub is shown in device language not in the preferred language that i set.

Sorry in advance for my bad english

@cozyplanes
Copy link
Contributor

Can not reproduce here (s8)

@Alex4386 한국인이신것같은데, fasthub 영어 설정, 디바이스 한국어 설정후 같은 증상이 일어나는지 확인 바랍니다

@Ibuprophen
Copy link

@Alex4386, it looks like you're trying to change the apps default locale/language as others have done when the app isn't picking up/using your devices default locale/language and is keeping English as the language.

To add... This app does have the Korean translation file as well...

Please refer to the following link that's very helpful in changing the apps language default instead of the app (unsuccessfully) looking to the device.

https://stackoverflow.com/questions/34573201/change-languages-in-app-via-strings-xml

I hope that it helps out... :-)

~Ibuprophen

@Alex4386
Copy link
Contributor Author

Alex4386 commented Jun 28, 2018

@cozyplanes
I am already set those. that is the reason i created this issue.

Korean

그 설정을 한 상태에서 문제가 발생해서 이슈를 생성한 것입니다.

@Alex4386
Copy link
Contributor Author

Alex4386 commented Jun 28, 2018

@ibuprophen1
That is NOT what it should work.

the stack overflow thread is just about localization in xml but that is not the case for me. the issue is, if i change the language via in-app settings, it does change language if i open fasthub directly via EDIT: app list (NOT the multitasking one) but via url, it does NOT.

Further Explanation

I already set the language of FastHub app language to English to use the app in English (via in-app settings).
The Problem is, the language setting does apply when i run app through EDIT: app list, but not through url in chrome (e.g. https://github.com/k0shk0sh/FastHub )

@Alex4386
Copy link
Contributor Author

Alex4386 commented Jun 28, 2018

Just found out launching from the EDIT: app list causes the same issue.

Closing issue for now.

@Alex4386
Copy link
Contributor Author

Alex4386 commented Jun 28, 2018

My bad. It is still occurring.
Will add screenshot for helping out further investigations.

@cozyplanes
Close all instances of FastHub and check Pull Request Tab to reproduce.

@Alex4386 Alex4386 reopened this Jun 28, 2018
@cozyplanes
Copy link
Contributor

cozyplanes commented Jun 28, 2018

@Alex4386 안녕하세요, 말씀하신 증상은 이쪽에서는 발생하지 않아서 확인하려고 합니다.
@Alex4386 님의 현재 설정은 다음과 같은 것으로 알고 있습니다

  1. 디바이스 언어 : ko_KR
  2. Fasthub 언어 : en_US
  3. 휴대폰의 최근 앱 목록에 Fasthub 없음

이 상황에서 https://github.com/k0shk0sh/FastHub/pulls 링크를 크롬애서 들어간 후 fasthub 로 공유하여 fasthub 애서 열었을 때 한국어 (디바이스 언어)로 나온다는 이야기인가요?

아니라면 스크린샷 과 함께 다시 올려주시면 감사하겠습니다. 재설치하시려면 설정에서 백업후 재설치 바립니다.
감사합니다.

  • Fasthub 한국어 번역자

Please check settings again and write a comment with screenshots explaining if the issue does not get resolved. Or you can try reinstalling after backing up settings.

@Alex4386
Copy link
Contributor Author

Alex4386 commented Jun 29, 2018

@cozyplanes Nope. I guess my words were confusing you.

Open FastHub via chrome

It is displayed in en-US as expected.

After I touched Pull Request Tab underneath

It is now displayed in ko-KR.

p.s. I really need to use in en-US due to ko-KR translations are misleading

@cozyplanes
Copy link
Contributor

Confirmed

@cozyplanes
Copy link
Contributor

@Alex4386 어떤 번역이 잘못되었거나 뜻이 전달이 안되는지 알려주시면 다음 업데이트에 반영하겠습니다.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants