Panic in Fcmp::prove when params contains too few Helios/Selene generators

[jeffro256]

When passed params contains too few generators compared to the passed branches, then a panic occurs on this line:

fcmp-plus-plus/crypto/fcmps/src/tape.rs

Line 232 in cbb5ffa

let g_generators = generators.g_bold_slice()[.. values.len()].iter().cloned();

IMO, some check should be made here and an Error returned if there aren't enough generators. Are there any other parts of the code that assume enough generators and take a slice without bounds checking?

[kayabaNerve]

https://github.com/kayabaNerve/fcmp-plus-plus/blob/develop/crypto%2Ffcmps%2Fsrc%2Flib.rs#L520

There is a NotEnoughGenerators error used in general. It just wasn't used by the prover-only commit to the VCs before actually instantiating the GBPs. Will try to put out a patch over the next few days, thanks for identifying.