Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches for SDL* even when ALSOFT_BACKEND_SDL* is OFF #1080

Open
ryandesign opened this issue Dec 11, 2024 · 1 comment
Open

Searches for SDL* even when ALSOFT_BACKEND_SDL* is OFF #1080

ryandesign opened this issue Dec 11, 2024 · 1 comment

Comments

@ryandesign
Copy link

cmake searches for SDL (with find_package) even if ALSOFT_BACKEND_SDL2 is OFF:

openal-soft/CMakeLists.txt

Lines 101 to 102 in 6790234

find_package(SDL3 QUIET)
find_package(SDL2 QUIET)

I can counteract this by using -DCMAKE_DISABLE_FIND_PACKAGE_SDL2=ON but I don't think I should have to do that. For all the other backends, the corresponding find_package call is not made if the backend is disabled.

@kcat
Copy link
Owner

kcat commented Dec 14, 2024

Commit 5c17dfd avoids searching for SDL2 when the backend is disabled. SDL3 still gets searched for since it's needed for a couple examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants