-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-user licenses #774
Conversation
108d6eb
to
f21756c
Compare
3cb566b
to
768706c
Compare
d045dd0
to
315c3d4
Compare
315c3d4
to
6e34579
Compare
As long as docs are updated, the migrations shouldn't take too long. I doubt a new account is going to swoop in, fully onboarded, trying to utilize the new endpoints within the time we deploy and the time our migrations complete. Skipping because this just adds an unnecessary step. |
eaeab5d
to
05b8264
Compare
CI is failing here and on master because a Ruby 3.2.3 image isn't available yet. Will re-run later. |
05b8264
to
3794d64
Compare
eae17f9
to
dcf4ec1
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Renamed #768. Closes #534. TL;DR: licenses had-one user, now licenses have-many users.
Prerequisites
user
validation scope to look atLicense#users
.Addowner
validation scope? (May be too ambiguous with license vs machine owner.)License#user
toLicense#owner
.user
relationship toowner
in user serializer.users
relationship to license serializer.data.relationships.owner
todata.relationship.user
for licenses (with updated links).RenameNot needed with v1x5 module.license.user.updated
webhook event tolicense.owner.updated
?Set default API version to v1.5 until post-deploy checklist is complete.Workaround in 7a61cb0.union_of
.Pre-deploy
license.users.attached
,license.users.detached
,license.owner.updated
,machine.owner.updated
event types.license.users.attach
,license.users.detach
,license.owner.update
,machine.owner.update
permissions.Post-deploy
Renamelicenses.user_id
tolicenses.owner_id
? (May want to do this during our next maintenance window?)RenameNot needed with v1x5 module.license.user.update
permission tolicense.owner.update
?Set default API version to v1.6.Workaround in 7a61cb0.union_of
to a gem.