Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using master #16

Open
lukehinds opened this issue Dec 29, 2019 · 4 comments
Open

Stop using master #16

lukehinds opened this issue Dec 29, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lukehinds
Copy link
Member

This role (unlike the role with master) is positioned for deploying Keylime into eventual production type environments. Thus it should be using releases and not building from master. We need a var in place, to allow users to pin to a specific release.

@lukehinds lukehinds added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 29, 2019
@dawud
Copy link
Contributor

dawud commented Jan 5, 2020

Using 'requirements.yml` allows to define "a tag value, commit hash, or branch name" to specify where to pull content from.
Moreover, Galaxy "imports any git tags matching the Semantic Version format as versions. In turn, a specific version of a role can be downloaded by specifying one of the imported tags".

If the intention is to provide this content to be consumed from Galaxy, I'd suggest tagging commits is a valid mechanism. Coupled with using feature branches for development activities.

@lukehinds
Copy link
Member Author

Sounds good to me @dawud , thank you for the input. Would you like to work on this / shall I assign to you?

@dawud
Copy link
Contributor

dawud commented Jan 5, 2020

Sure, thanks.

@lukehinds
Copy link
Member Author

Thanks are all mine. If when you're happy, feel free to get something set up on galaxy or poke me to do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants