Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Feature requests: A) Default transport, and B) Default path for email templates #9

Open
mldangelo opened this issue Sep 10, 2016 · 0 comments

Comments

@mldangelo
Copy link

Hi!

Awesome work so far! I'm migrating my keystone 3.x project to the 4.x beta. These are two quick features that I think could ease migration and make code syntactically simpler. I'll happily submit PR's for each of them. They could be set as environmental variables or in a config file that keystone-email looks for. If we go with the config file option, we could also add default locals.

A) Allow a default option for transport to be set as an environmental variable Something like process.env.transport, so we can declare:

new Email('templatepath.ext')

instead of:

new Email('templatepath.ext', { transport: 'mailgun' })

Which would be especially useful in projects like mine, where I have 17 email templates. Specifying a transport could override process.env.transport.

B) I think this feature is less useful. I'd like to allow a default template path. I've had to prepend templates/emails/ to all of my email templates. I would have preferred to set this in a configuration file.

Thanks for your consideration!

@mldangelo mldangelo changed the title Feature requests: A) Allow a default transport, and B) Allow a default path for email templates Feature requests: A) Default transport, and B) Allow a default path for email templates Sep 10, 2016
@mldangelo mldangelo changed the title Feature requests: A) Default transport, and B) Allow a default path for email templates Feature requests: A) Default transport, and B) Default path for email templates Sep 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant