Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KATC sqlite scanning #2109

Open
RebeccaMahany opened this issue Feb 18, 2025 · 0 comments
Open

Improve KATC sqlite scanning #2109

RebeccaMahany opened this issue Feb 18, 2025 · 0 comments
Labels
features-improvements Features and Improvements

Comments

@RebeccaMahany
Copy link
Contributor

Right now, the sqlite dataFunc scans the value for every column into a []byte, regardless of its underlying type. This is convenient for our data processing functions -- but does mean that we hit some weird edge cases. For example, float64 date columns will be formatted in scientific notation (per https://cs.opensource.google/go/go/+/refs/tags/go1.24.0:src/database/sql/convert.go;l=532).

We may want to revisit how we're scanning in the data to handle these use cases a little more cleanly.

See: https://github.com/kolide/launcher/blob/main/ee/katc/sqlite.go

@RebeccaMahany RebeccaMahany added component:table Table Changes features-improvements Features and Improvements and removed component:table Table Changes labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

No branches or pull requests

1 participant