You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Equilibrium object loaded via pleque.io.compass.cdb() has .shot=0. This then causes further minor inconveniences such as the loss of this metadata when writing the equilibrium into a file, e.g. to_geqdsk(). While I usually depend on the filename to store this metadata (shot number and time) I feel like it would be nice to have this additional backup given that this is already a feature of the eqdsk format.
Proposal for fix:
Probaly just add something like
# Accessing `sig_ref` instead of parameter `shot` should handle cases when user uses `shot=None`
eq.shot = sig_ref.record_number
Currently,
Equilibrium
object loaded viapleque.io.compass.cdb()
has.shot=0
. This then causes further minor inconveniences such as the loss of this metadata when writing the equilibrium into a file, e.g.to_geqdsk()
. While I usually depend on the filename to store this metadata (shot number and time) I feel like it would be nice to have this additional backup given that this is already a feature of the eqdsk format.Proposal for fix:
Probaly just add something like
added just below
pleque/pleque/io/compass.py
Line 40 in a414deb
Proposal for further investigation:
io
options (such ascudb
) and how they handle theshot
attribute, potentially fix them as wellThe text was updated successfully, but these errors were encountered: