Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpc-nat-gateway annotation question. #5027

Open
inyongma1 opened this issue Feb 25, 2025 · 3 comments
Open

vpc-nat-gateway annotation question. #5027

inyongma1 opened this issue Feb 25, 2025 · 3 comments

Comments

@inyongma1
Copy link

Does vpc-nat-gateway annotation is used only "kubernetes.io/hostname" and "kubernetes.io/os" these label bc I saw the code It seems like I can define the label.

kind: VpcNatGateway
apiVersion: kubeovn.io/v1
metadata:
name: gw1
spec:
vpc: test-vpc-1
subnet: net1
lanIp: 10.0.1.254
selector:
- "kubernetes.io/hostname: kube-ovn-worker"
- "kubernetes.io/os: linux"
externalSubnets:
- ovn-vpc-external-network

Copy link

dosubot bot commented Feb 25, 2025

The selector field in the VpcNatGateway specification allows you to define custom labels, not just limited to "kubernetes.io/hostname" and "kubernetes.io/os". You can specify any labels that match the nodes you want to target. The function isVpcNatGwChanged in the kube-ovn codebase processes the selector field by checking if it has changed compared to the status, which indicates that you can define and use custom labels in the selector field [1].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@inyongma1
Copy link
Author

what dosubot commented is right??

@zbb88888
Copy link
Collaborator

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants