Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] extend ProviderNetwork with includeNodes and label support #5039

Open
dgsponer opened this issue Feb 27, 2025 · 0 comments
Labels
enhancement Improve exist functions feature New network feature

Comments

@dgsponer
Copy link

dgsponer commented Feb 27, 2025

Description

Dear Devs,

during setup an environment, we got few time the issue, that in the network provider config hosts are missing or wrong annotated.

is it possible to extend this mechanism by an includeNodes and add by-label feature?

this is the manifest from the docu

apiVersion: kubeovn.io/v1
kind: ProviderNetwork
metadata:
  name: net1
spec:
  defaultInterface: eth1
  customInterfaces:
    - interface: eth2
      nodes:
        - node1
  excludeNodes:
    - node2

some examples for an implementation:

apiVersion: kubeovn.io/v1
kind: ProviderNetwork
metadata:
  name: net1
spec:
  defaultInterface: eth1
  customInterfaces:
    - interface: eth2
      nodes:
        - node1
  includeNodes:
    - labels: node-role.kubernetes.io/worker
    - nodes:
       - node2
apiVersion: kubeovn.io/v1
kind: ProviderNetwork
metadata:
  name: net1
spec:
  defaultInterface: eth1
  customInterfaces:
    - interface: eth2
      nodes:
        - node1
  excludeNodes:
    - labels: node-role.kubernetes.io/worker

Who will benefit from this feature?

Me, and customers how be able to change the node roles dynamically.

Anything else?

No response

@dgsponer dgsponer added the feature New network feature label Feb 27, 2025
@dgsponer dgsponer changed the title [Feature Request] [Feature Request] extend ProviderNetwork with includeNodes and label support Feb 27, 2025
@dosubot dosubot bot added the enhancement Improve exist functions label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve exist functions feature New network feature
Projects
None yet
Development

No branches or pull requests

1 participant