Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Utilize tilt-provider.yaml and Tilt deploy approach from the Cluster API #726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Utilize tilt-provider.yaml and Tilt deploy approach from the Cluster API #726

wants to merge 1 commit into from

Conversation

dmvolod
Copy link
Member

@dmvolod dmvolod commented Feb 14, 2025 •
edited
Loading

What this PR does / why we need it:
This PR adopts tilt utilizing approach from the Cluster API for deploying and debugging operator.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #719

Some issue need to be fixed in Cluster API Tiltfile to avoid Cluster API Core Provider bootstrapping together with the operator

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danil-grigorev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 14, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit a93fc0e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67af60a89d601200087b8065
😎 Deploy Preview https://deploy-preview-726--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmvolod dmvolod mentioned this pull request Feb 17, 2025
Closed
@dmvolod
Copy link
Member Author

dmvolod commented Feb 20, 2025

/hold

Will continue, when kubernetes-sigs/cluster-api#11879 will merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@dmvolod dmvolod marked this pull request as ready for review February 20, 2025 10:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add debug option to Tiltfile
2 participants
@dmvolod @k8s-ci-robot