Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: graceperiodseconds option in e2e test #1622

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: graceperiodseconds option in e2e test #1622

wants to merge 1 commit into from

Conversation

googs1025
Copy link
Member

@googs1025 googs1025 commented Feb 2, 2025 •
edited
Loading

  • fix graceperiodseconds e2e test

Fix: #1605

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2025
@googs1025
Copy link
Member Author

/test all

@googs1025
Copy link
Member Author

/test all

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025 googs1025 force-pushed the fix/graceful_e2e branch 2 times, most recently from 87519b8 to 8ae12e8 Compare February 2, 2025 09:03
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-31

@googs1025 googs1025 force-pushed the fix/graceful_e2e branch 2 times, most recently from 278a34c to 7824df7 Compare February 2, 2025 10:30
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

1 similar comment
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

1 similar comment
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025 googs1025 changed the title fix: graceperiodseconds e2e test fix: graceperiodseconds option in e2e test Feb 2, 2025
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

It seems that there are still some issues that have not been resolved. I need to investigate again. ....

@googs1025 googs1025 marked this pull request as draft February 3, 2025 12:30
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

1 similar comment
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

1 similar comment
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

2 similar comments
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025 googs1025 force-pushed the fix/graceful_e2e branch 2 times, most recently from 2cccf1f to f026280 Compare February 4, 2025 05:00
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

3 similar comments
@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@googs1025
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-30
/test pull-descheduler-test-e2e-k8s-master-1-31
/test pull-descheduler-test-e2e-k8s-master-1-32

@k8s-ci-robot
Copy link
Contributor

@googs1025: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-test-e2e-k8s-master-1-32 cd2f8b1 link true /test pull-descheduler-test-e2e-k8s-master-1-32
pull-descheduler-test-e2e-k8s-master-1-30 cd2f8b1 link true /test pull-descheduler-test-e2e-k8s-master-1-30
pull-descheduler-test-e2e-k8s-master-1-31 cd2f8b1 link true /test pull-descheduler-test-e2e-k8s-master-1-31

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklaw90 jklaw90 Awaiting requested review from jklaw90

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@damemi damemi Awaiting requested review from damemi

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@a7i a7i Awaiting requested review from a7i

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test: TestTooManyRestarts/test-one-evictions-use-gracePeriodSeconds
3 participants
@googs1025 @k8s-ci-robot @ingvagabund