-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RouteGroup support #1403
Comments
While I'm not opposed to that, I would encourage to try to see if we can find a way to make this a plugin or opt in via build tags. I understand the value of this for zalando, but this crd is new and still not widely used in the community. I would love to avoid supporting very specific company centric implementations. |
I opened a discussion issue in #1447. |
I don't think we are being biased towards cloud providers. The early support of Istio's CRD was probably a mistake but now it's in and there isn't much that we can do for now. We can evaluate in the future what to do with it based on how #1447 will evolve.
I'm sorry for that. I'm willing to bring the conversation in #1447 further depending on availability and I'm open to set up a call as early as next week if you think it would be helpful to brainstorm a solution together. Of course, I can suggest you to use a temporary fork of External DNS, with the goal of not having you rely on it for too long as this would be clearly a failure for the project itself. |
I think PRs can be independently merged from #1447 and if the decision is to remove all CRDs or everything after date X, I am fine to have the routegroups source to be removed. WDYT? |
I don't see any problem with that. I think we should hold on merging additional CRDs aside from this one to avoid having problems bringing them out. |
@szuecs I think there are even more implications around rolling out RouteGroup within Zalando, many tools currently rely on Ingress (e.g. hjacobs/kube-resource-report#129) and need to be adapted. I also use Ingress hostnames for dependency detection via OpenTracing's |
RouteGroup support was merged, so this issue can be closed |
RouteGroup are supported by skipper and kube-ingress-aws-controller.
In order to automate DNS for this CRD type we have to implement a new source.
CRD details:
hosts
Example:
I will soon send a PR for this @linki @njuettner
The text was updated successfully, but these errors were encountered: