-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy-protocol is not actually supported on GKE using the default LoadBalancer service. #12829
Comments
We don't test on GKE. Somone can potentially create GKE cluster and reproduce but it costs money and time. Have you found the right way to enable proxy-protocol already and are just reporting this as a docs error ? Or you have not been able to enable proxy protocol on GCP LB ? |
I'm reporting this as a docs error, to the best of my knowledge, a way to achieve this would involve
Probably something else, after realizing that, I did not follow that route, my goal was to switch to proxy protocol to retain real IP addresses, but in the end, I decided that the added complexity is not worth it, when the alternative exists (using DaemonSet and setting |
I am not convinced until I get reliable data. I think the effort is limited to editing the LB created by the ingress-controller install. But it will be a while before I can test. @Gacko will comment if he already knows more details about this. |
@mzglinski We do not test configurations against clouds regularly in our CI; it is only with kind; docs go out of date as providers update services; it may have worked at one time. Please don't hesitate to update the documentation to reflect a known working status. |
/priority backlog |
What happened
The ingress-nginx deployment documentation for GKE (https://kubernetes.github.io/ingress-nginx/deploy/#gce-gke) states that "Proxy-protocol is supported in GCE check the Official Documentations on how to enable.". When you check the GCE documentation and try to follow the instructions, you will realize that enabling Proxy protocol on an existing Passthrough load balancer is impossible, which is the type of LB created by default.
However, when checking the GKE LoadBalancer Service parameters documentation (https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer-parameters), there is no annotation available to enable proxy protocol for the default LoadBalancer service.
This creates confusion for users trying to enable proxy protocol on GKE, as the documentation suggests it's supported but provides no clear way to enable it.
What you expected to happen
The documentation should either:
How to reproduce
Environment
/kind documentation
/remove-kind feature
The text was updated successfully, but these errors were encountered: