Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automated cherry-picks for karpenter #1543

Open
liangyuanpeng opened this issue Aug 8, 2024 · 3 comments · May be fixed by kubernetes/test-infra#33295
Open

Enable automated cherry-picks for karpenter #1543

liangyuanpeng opened this issue Aug 8, 2024 · 3 comments · May be fixed by kubernetes/test-infra#33295
Assignees
@liangyuanpeng
Labels
kind/automation Issues about the Karpenter's automation processes kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Aug 8, 2024 •
edited
Loading

Description

What problem are you trying to solve?

I can see that there are some PR for backport, and i believe that the cherrypick plugin will simplify this process, just only need to comment /cherry-pick release-v0.37.x at origin PR and then the bot will create a PR for release-v0.37.x, see cluster api project how to use it: kubernetes-sigs/cluster-api#10988 (comment)

Before I open a PR at test-infra to enable plugin for karpenter I hope we can reach a consensus.

/assign
/cc @engedaam @jonathan-innis

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@liangyuanpeng liangyuanpeng added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@njtran
Copy link
Contributor

njtran commented Aug 12, 2024

Is this purely to do automated cherry-picks? This seems interesting! We've done most of our cherry-picks for this upcoming release, but definitely interested to see how this works.

@njtran njtran added kind/automation Issues about the Karpenter's automation processes and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 12, 2024
@liangyuanpeng liangyuanpeng changed the title Enable cherrypick plugin for karpenter Enable automated cherry-picks for karpenter Aug 12, 2024
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Aug 12, 2024 •
edited
Loading

Is this purely to do automated cherry-picks?

exactly!

Basically, it is a cherry pick plugin owned by the Kubernetes community, i will open a PR at https://github.com/kubernetes/test-infra to enable cherry pick pligun for karpenter, and then need the karpenter maintainer LGTMs and approves the PR. Then I will look for the test-infra lead to merge the PR.

Once the cherrypick plugin is enabled for the karpenter repo, you can ask the bot to open a backport PR for the release-v0.37.x branch by commenting /cherry-pick release-v0.37.x on the original PR

@liangyuanpeng liangyuanpeng linked a pull request Aug 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liangyuanpeng liangyuanpeng

Labels
kind/automation Issues about the Karpenter's automation processes kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cherrypicker plugin to K8s-sigs/karpenter. liangyuanpeng/kubernetes-test-infra
3 participants
@njtran @k8s-ci-robot @liangyuanpeng