Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sachin-Bhat
Copy link

@Sachin-Bhat Sachin-Bhat commented Jul 17, 2024

Hello @eyurtsev,

Here are the list of changes:

  • kork/chain.py:
    • Removal of LLMChain in favor of RunnableSequence as per LCEL
    • Fixing some imports
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
    • Removal of cast() and predict_and_parse() in favor of .content and invoke()
  • kork/parser.py:
    • convert the GRAMMAR to a raw string
  • kork/prompt_adapter.py:
    • Fixing some imports
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
  • tests/test_chain.py:
    • removing Chain.__call__() in favor of .invoke()
  • tests/test_prompt_adapter.py:
    • Fixing some imports
  • tests/utils.py:
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
    • addition of property _llm_type() to ensure that the test_chain passes since .invoke() needs this property to function correctly

Merging this fixes #24. Please let me know if further changes are required or if I have missed something.

Cheers,
Sachin

@Sachin-Bhat
Copy link
Author

@eyurtsev are we planning a merge soon?

@eyurtsev
Copy link
Collaborator

eyurtsev commented Aug 1, 2024

Hi @Sachin-Bhat,

Kork is a prototype for agents that can take multiple sequential actions at once, but it isn't really used by the community https://pypistats.org/packages/kork, so we're not maintaining it.

We can keep the PR open in case anything changes but for now it's hard to justify putting any work at all into this package.

Eugene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated calls in the workflow
2 participants