Fix ChatBedrock integration with Amazon Bedrock model #339
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes langchain-ai#308 Update the `ChatBedrock` class to handle the `region_name` parameter correctly. * Modify `libs/aws/langchain_aws/chat_models/bedrock.py` to ensure the `region_name` parameter is passed to the `ChatBedrockConverse` class and add logic to take `region_name` from `AWS_REGION` environment variable if not provided. * Add test cases in `libs/aws/tests/integration_tests/chat_models/test_bedrock_converse.py` to confirm that `ChatBedrockConverse` works with the `amazon.nova-pro-v1:0` model and takes `region_name` from `AWS_REGION` environment variable if not provided. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/langchain-ai/langchain-aws/issues/308?shareId=XXXX-XXXX-XXXX-XXXX).
|
Good job! I've been forgetting to set it cuz all AWS services were already able to get the environment variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Update the
ChatBedrockclass to handle theregion_nameparameter correctly.libs/aws/langchain_aws/chat_models/bedrock.pyto ensure theregion_nameparameter is passed to theChatBedrockConverseclass and add logic to takeregion_namefromAWS_REGIONenvironment variable if not provided.libs/aws/tests/integration_tests/chat_models/test_bedrock_converse.pyto confirm thatChatBedrockConverseworks with theamazon.nova-pro-v1:0model and takesregion_namefromAWS_REGIONenvironment variable if not provided.For more details, open the Copilot Workspace session.