Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing error in RedisVectorStore.add_texts() #49

Open
adriendwl opened this issue Jan 22, 2025 · 1 comment
Open

Typing error in RedisVectorStore.add_texts() #49

adriendwl opened this issue Jan 22, 2025 · 1 comment
Assignees

Comments

@adriendwl
Copy link

Hi everyone,

I had some typing problem using RedisVectorStore.add_texts() function. For the keys input, a list of dictionaries is requested (Optional[List[dict]]) , while it's used as a list of string when loaded later (keys=[f"{self.config.key_prefix}:{key}" for key in keys]).

The typing should be Optional[List[str]] such as in the from_texts function where a # type: ignore is used no ?

Or maybe is there a reason for this typing I don't get ?

Thanks for your answer 😅

@abrookins abrookins self-assigned this Jan 24, 2025
@abrookins
Copy link
Collaborator

Thanks for reporting, @adriendwl! I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants