From 0b594b1ea4becbee5ee6da0ab5ab3e58f97823a1 Mon Sep 17 00:00:00 2001
From: Liam <liam@ten.dev>
Date: Fri, 10 Jan 2025 17:38:58 +0000
Subject: [PATCH 1/2] feat(js): add dataset version to evaluate response

---
 js/src/evaluation/_runner.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/js/src/evaluation/_runner.ts b/js/src/evaluation/_runner.ts
index 6c74afa34..a33ccd5be 100644
--- a/js/src/evaluation/_runner.ts
+++ b/js/src/evaluation/_runner.ts
@@ -894,6 +894,7 @@ class ExperimentResults implements AsyncIterableIterator<ExperimentResultRow> {
   results: ExperimentResultRow[] = [];
   processedCount = 0;
   summaryResults: EvaluationResults;
+  datasetVersion: string | undefined;
 
   constructor(experimentManager: _ExperimentManager) {
     this.manager = experimentManager;
@@ -923,6 +924,7 @@ class ExperimentResults implements AsyncIterableIterator<ExperimentResultRow> {
       this.processedCount++;
     }
     this.summaryResults = await manager.getSummaryScores();
+    this.datasetVersion = await manager._getDatasetVersion();
   }
 
   get length(): number {

From 9a62e7fbd085ff1972c7d3b4bc97fd0e6520f05c Mon Sep 17 00:00:00 2001
From: Liam <liam@ten.dev>
Date: Tue, 14 Jan 2025 10:38:07 +0000
Subject: [PATCH 2/2] move dataset version to start

---
 js/src/evaluation/_runner.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/js/src/evaluation/_runner.ts b/js/src/evaluation/_runner.ts
index a33ccd5be..058f37099 100644
--- a/js/src/evaluation/_runner.ts
+++ b/js/src/evaluation/_runner.ts
@@ -483,6 +483,7 @@ export class _ExperimentManager {
     const project = await this._getProject(firstExample);
     await this._printExperimentStart();
     this._metadata["num_repetitions"] = this._numRepetitions;
+    this._metadata["dataset_version"] = await this._getDatasetVersion();
     return new _ExperimentManager({
       examples,
       experiment: project,
@@ -869,7 +870,6 @@ export class _ExperimentManager {
       throw new Error("Experiment not yet started.");
     }
     const projectMetadata = await this._getExperimentMetadata();
-    projectMetadata["dataset_version"] = await this._getDatasetVersion();
     projectMetadata["dataset_splits"] = await this._getDatasetSplits();
     // Update revision_id if not already set
     if (!projectMetadata["revision_id"]) {
@@ -894,7 +894,6 @@ class ExperimentResults implements AsyncIterableIterator<ExperimentResultRow> {
   results: ExperimentResultRow[] = [];
   processedCount = 0;
   summaryResults: EvaluationResults;
-  datasetVersion: string | undefined;
 
   constructor(experimentManager: _ExperimentManager) {
     this.manager = experimentManager;
@@ -904,6 +903,10 @@ class ExperimentResults implements AsyncIterableIterator<ExperimentResultRow> {
     return this.manager.experimentName;
   }
 
+  get datasetVersion(): string | undefined {
+    return this.manager._metadata?.dataset_version;
+  }
+
   [Symbol.asyncIterator](): AsyncIterableIterator<ExperimentResultRow> {
     return this;
   }
@@ -924,7 +927,6 @@ class ExperimentResults implements AsyncIterableIterator<ExperimentResultRow> {
       this.processedCount++;
     }
     this.summaryResults = await manager.getSummaryScores();
-    this.datasetVersion = await manager._getDatasetVersion();
   }
 
   get length(): number {