Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected tag creation when pressing enter during tag conversion #13039

Closed
5 tasks done
miya opened this issue Jan 25, 2025 · 1 comment · Fixed by #13041
Closed
5 tasks done

Unexpected tag creation when pressing enter during tag conversion #13039

miya opened this issue Jan 25, 2025 · 1 comment · Fixed by #13041
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report

Comments

@miya
Copy link
Contributor

miya commented Jan 25, 2025

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.15.2

Cloud or Self Hosted

Cloud

Steps to reproduce

  1. Access /apps
  2. Hover over any App
  3. Click "Add tag"
  4. Click "Manage Tags"
  5. Enter text that needs conversion, press enter to confirm the conversion
2025-01-25.18.29.32.mov

✔️ Expected Behavior

Prevent tag creation when pressing enter to confirm text conversion

❌ Actual Behavior

Tag is created when pressing enter to confirm text conversion

Copy link

dosubot bot commented Jan 25, 2025

Hello, @miya! I'm here to help you with bug reports, questions, and becoming a contributor. Let's work together to solve this issue.

The issue you're experiencing with unexpected tag creation when pressing 'Enter' during tag conversion is related to the conditional logic in the code. The behavior is determined by the customizedConfirmKey prop and the isSpecialMode variable. If isSpecialMode is false and the customizedConfirmKey is set to 'Enter', the code will attempt to add the trimmed input value as a new tag if it meets certain conditions (not empty, not already in the list, and not longer than 20 characters) [1].

To address this issue, you might need to adjust the logic to differentiate between confirming text conversion and creating a new tag. This could involve modifying the conditions under which a tag is created when the 'Enter' key is pressed, especially in scenarios where text conversion is intended.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added cloud When the version is cloud and it is a bug report 🐞 bug Something isn't working labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant