Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpinerEOSDependsRhoSie doesn't have the same cold curve infrastructure that SpinerEOSDependsRhoT does #474

Open
jhp-lanl opened this issue Mar 3, 2025 · 0 comments
Open

SpinerEOSDependsRhoSie doesn't have the same cold curve infrastructure that SpinerEOSDependsRhoT does #474

jhp-lanl opened this issue Mar 3, 2025 · 0 comments
Assignees
@Yurlungur @jonahm-LANL

Comments

@jhp-lanl
Copy link
Collaborator

jhp-lanl commented Mar 3, 2025 •
edited
Loading

@jonahm-LANL It looks like SpinerEOSDependsRhoSie doesn't have the same cold curve infrastructure that SpinerEOSDependsRhoT does so I left that function disabled. It's probably faster for you to add the required functionality than it is for me.

Sounds good. I'll add it in a subsequent MR.

This is ready for final review (really just the test was added, but there are a few more changes)

Originally posted by @Yurlungur in #375 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yurlungur Yurlungur

@jonahm-LANL jonahm-LANL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yurlungur @jonahm-LANL @jhp-lanl