Destroy method doesn't wait for resolution of closes

[zemccartney]

Heyo! First off, thanks a lot for the hard work here. I recently pulled this into my project using Puppeteer, provided a tremendous performance boost. Much, much appreciated 🙏

May or may not be an issue, but I noticed that because the destroy method doesn't wait for the close method to resolve (https://github.com/latesh/puppeteer-pool/blob/master/src/index.js#L26), any errors while closing aren't caught, potentially (actually, in my case :) ) resulting in uncaught promise rejections. I ended up fixing by just returning instance.close(), but wasn't sure if that was shortsighted.

Is this an issue or (I'm thinking, though hoping otherwise :) ) did I miss something important as to why we don't want to return and wait on the resolution of instance.close from the destroy method?

thanks again! sorry if any of the above is unclear

[aksharj]

Hi @zemccartney @ @latesh

I am seeing a similar issue where the browser does not close and remains open.

Is there a fix you guys implemented?

Any help would be really great. Thanks