how to use this repo with gin? #73
Comments
|
For http, we can use gin router like this: package main
import (
"context"
"fmt"
"net/http"
"os"
"os/signal"
"time"
"github.com/gin-gonic/gin"
"github.com/lesismal/nbio/nbhttp"
)
func main() {
router := gin.New()
router.GET("/hello", func(c *gin.Context) {
c.String(http.StatusOK, "hello")
})
svr := nbhttp.NewServer(nbhttp.Config{
Network: "tcp",
Addrs: []string{"localhost:8080"},
}, router, nil)
err := svr.Start()
if err != nil {
fmt.Printf("nbio.Start failed: %v\n", err)
return
}
interrupt := make(chan os.Signal, 1)
signal.Notify(interrupt, os.Interrupt)
<-interrupt
ctx, cancel := context.WithTimeout(context.Background(), time.Second*3)
defer cancel()
svr.Shutdown(ctx)
}For websocket, we can not use this repo for gin or other std based repo with other std based websocket frameworks, because the std based repo websocket frameworks does not support non-blocking, their Upgrade and Read/Writte interfaces are still blocked which may make the application layer's goroutine pool blocked, then the service becomes slow or even not available. package main
import (
"context"
"fmt"
"net/http"
"os"
"os/signal"
"time"
"github.com/gin-gonic/gin"
"github.com/lesismal/nbio/nbhttp"
"github.com/lesismal/nbio/nbhttp/websocket"
)
type HttpHandler struct {
router *gin.Engine
}
func (h *HttpHandler) OnWebsocket(w http.ResponseWriter, r *http.Request) {
upgrader := websocket.NewUpgrader()
conn, err := upgrader.Upgrade(w, r, nil)
if err != nil {
panic(err)
}
wsConn := conn.(*websocket.Conn)
wsConn.OnMessage(func(c *websocket.Conn, messageType websocket.MessageType, data []byte) {
// echo
fmt.Println("websocket:", messageType, string(data), len(data))
c.WriteMessage(messageType, data)
})
wsConn.OnClose(func(c *websocket.Conn, err error) {
fmt.Println("OnClose:", c.RemoteAddr().String(), err)
})
fmt.Println("OnOpen:", wsConn.RemoteAddr().String())
}
func (h *HttpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case "/ws":
h.OnWebsocket(w, r)
default:
h.router.ServeHTTP(w, r)
}
}
func main() {
router := gin.New()
router.GET("/hello", func(c *gin.Context) {
c.String(http.StatusOK, "hello")
fmt.Println("http: hello")
})
svr := nbhttp.NewServer(nbhttp.Config{
Network: "tcp",
Addrs: []string{"localhost:8080"},
}, &HttpHandler{router}, nil)
err := svr.Start()
if err != nil {
fmt.Printf("nbio.Start failed: %v\n", err)
return
}
interrupt := make(chan os.Signal, 1)
signal.Notify(interrupt, os.Interrupt)
<-interrupt
ctx, cancel := context.WithTimeout(context.Background(), time.Second*3)
defer cancel()
svr.Shutdown(ctx)
}Or if there is a way to get the origin ResponseWriter from gin.Context(but I'm not sure how to get it), we can use nbio/nbhttp/websocket like this: r := c.Request
w := c.SomeGetOriginHttpResponseWriterInterface()
upgrader := websocket.NewUpgrader()
conn, err := upgrader.Upgrade(w, r, nil)
... |
|
广州的？咱们中文吧。 其他的websocket框架，比如 gorilla/websocket，他们的 Upgrade/Read/Write 是阻塞的，如果poller本次读时间只有半个 http Upgrade Request或者半个websocket frame， 他们的 Upgrade/Read 就会失败。 还有像 gobwas/ws 这个库配合他们所说的 netpoll 方案，因为也是同样没有实现异步流解析，它的Upgrade/Read/Write也同样存在阻塞的问题，会导致应用层协程池占用甚至耗尽、服务变慢甚至不可用。前几年流行的一个关于golang websocke百万连接的帖子和仓库就是基于 gobwas/ws 的方案，但是他们的方案都存在这个问题。我有在他们的仓库中指出这个问题，有兴趣可以去他们的仓库issue列表里搜一下我相关的issue。 异步非阻塞库的目的是减少高并发场景的协程数量，进而减少内存占用量、gc压力、调度压力等；
nbio目前是完整实现了这些的，还支持异步tls 其他已有方案，除了 gev 的websocket是实现了异步流解析（但是实现较为简单、不够完善），其他已知的golang异步非阻塞网络库均没有实现异步流解析，其他的基于std的框架也都存在Upgrade/Read/Write阻塞的问题、无法用于poller方案。 |
OnDataFrame是收到帧，使用它时应该让协程池有序处理每一帧，nbhttp默认使用的协程池是无序的，如果使用OnDataFrame，应该配合有序协程池，比如： OnMessage收到的消息是完整的，无需自己再进行frame拼接，处理OnMessage的默认协程池是无序的，如果需要保证有序处理单个连接的websocket消息，也可以使用这个有序协程池： 另外，关于异步网络框架配合同步业务逻辑的方案，要注意业务协程池的数量、其他IO阻塞场景等的参数配合，比如协程池的size可以根据自家业务实测情况的需要进行设置： messageHandlerExecutePool := taskpool.NewFixedPool(100, 1000)异步网络层+同步业务逻辑的具体影响在 gev 的讨论帖中有聊到，有兴趣可以来看看： |
|
提交了一些新的代码发布了，最新版本不需要上面那种HttpHandler的Wrap了，但websocket仍需要使用nbhttp的，gin的完整示例： package main
import (
"context"
"fmt"
"net/http"
"os"
"os/signal"
"time"
"github.com/gin-gonic/gin"
"github.com/lesismal/nbio/nbhttp"
"github.com/lesismal/nbio/nbhttp/websocket"
)
func main() {
router := gin.New()
router.GET("/hello", func(c *gin.Context) {
c.String(http.StatusOK, "hello")
fmt.Println("http: hello")
})
router.GET("/ws", func(c *gin.Context) {
w := c.Writer
r := c.Request
upgrader := websocket.NewUpgrader()
conn, err := upgrader.Upgrade(w, r, nil)
if err != nil {
panic(err)
}
wsConn := conn.(*websocket.Conn)
wsConn.OnMessage(func(c *websocket.Conn, messageType websocket.MessageType, data []byte) {
// echo
fmt.Println("websocket:", messageType, string(data), len(data))
c.WriteMessage(messageType, data)
})
wsConn.OnClose(func(c *websocket.Conn, err error) {
fmt.Println("OnClose:", c.RemoteAddr().String(), err)
})
fmt.Println("OnOpen:", wsConn.RemoteAddr().String())
})
svr := nbhttp.NewServer(nbhttp.Config{
Network: "tcp",
Addrs: []string{"localhost:8888"},
}, router, nil)
err := svr.Start()
if err != nil {
fmt.Printf("nbio.Start failed: %v\n", err)
return
}
interrupt := make(chan os.Signal, 1)
signal.Notify(interrupt, os.Interrupt)
<-interrupt
ctx, cancel := context.WithTimeout(context.Background(), time.Second*3)
defer cancel()
svr.Shutdown(ctx)
} |
|
thank you for your reply. |
There's something hard to explain in English due to my poor English, so I replied in Chinese 😂
Just use: wsConn.Close()
I'm afraid it is not that easy as you think... 😂
I did spend time thinking of a good name, but I failed to think of a good name. . . |
|
Hi @lesismal, I use your example to combine |
Thank you for your attention and feedback! func onWebsocket(c *gin.Context) {
var userInfo *YourType := getFromGinContext(c)
upgrader := websocket.NewUpgrader()
upgrader.OnMessage(func(c *websocket.Conn, messageType websocket.MessageType, data []byte) {
// step 2: get your session info
session := c.Session();
if session == nil {
c.Close()
// do something with user
return
}
user := session.(*YourType)
// do something with user
})
w := c.Writer
r := c.Request
conn, err := upgrader.Upgrade(w, r, nil)
if err != nil {
// ...
return
}
wsConn := conn.(*websocket.Conn)
wsConn.OnClose(func(c *websocket.Conn, err error) {
// ...
})
// step 1: save your session info
wsConn.SetSession(userInfo)
} |
|
@lesismal thank you so much! I tried it. Perfect! It is working like a charm. So with that, it is possible to combine |
|
@Jekinnnnnn 翻了下以往的回复
现在的版本，每个Conn对应的OnDataFrame、OnMessage的执行都是默认有序的了 |
|
This issue is stale because it has been open for 30 days with no activity. |
|
This issue was closed because it has been inactive for 14 days since being marked as stale. |
our project use gin as http router,and upgrade websocket request in gin handler with websocket lib,
but this repo seem need to register http handle with repo own server.
is there has a way to use this repo like other websocket libs?
besides,i notice the api OnDataFrame,if server should work with half a pack when client send big data with frames?
can i assume data is complete when callling handler OnMessage?
The text was updated successfully, but these errors were encountered: