Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Styling Improvements #60

Open
thousand opened this issue Dec 15, 2021 · 1 comment
Open

General Styling Improvements #60

thousand opened this issue Dec 15, 2021 · 1 comment

Comments

@thousand
Copy link

Seeing #59 and noticing a lack of dark mode support, I thought I'd offer to do a pass over the styles to make these and a few other improvements in a batch.

  • Address Visual cue for visited links #59 and make some other legibility tweaks
  • Refactor and modernize the CSS to reduce the page weight (not that it's huge) and make future changes easier
  • Add a dark color scheme and support for system dark mode (and/or provide a manual toggle)
  • Make the main content and book page more visually consistent

Let me know how this all sounds, if there's any guidance or patterns i should follow, and if there's anything else that could be done.

@lethain
Copy link
Owner

lethain commented Dec 16, 2021

Hi @thousand -- I'd be quite grateful if you submitted a PR that handled those. I don't have any strong points of view other than trying to keep submission process simple (e.g. just adding a markdown file) which I don't imagine your proposed changes would impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@lethain @thousand and others