Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subdomain fallback #4

Open
kamilmielnik opened this issue Dec 5, 2022 · 3 comments
Open

Improve subdomain fallback #4

kamilmielnik opened this issue Dec 5, 2022 · 3 comments

Comments

@kamilmielnik
Copy link
Contributor

See online.mbank.pl vs mbank.pl.
The first one only has 16x16px favicon.ico, but the second one has nice 180x180 favicon.

@yuriyyakym
Copy link
Contributor

Subdomain may have completely different icon, I'm not sure it's a good idea to fallback to a domain's one.
Eg. https://mail.google.com/favicon.ico

@kamilmielnik
Copy link
Contributor Author

kamilmielnik commented Dec 7, 2022

Subdomain may have completely different icon, I'm not sure it's a good idea to fallback to a domain's one. Eg. https://mail.google.com/favicon.ico

In this case we'd have icon of the company who made the product instead of an icon of the product.
Is it really that bad? I think it's better than no icon.
And it works for the example I originally gave.

Anyway, fallback is not necessary here, so it's not a real case.
Any real-life counter-examples?

@yuriyyakym
Copy link
Contributor

You're right, but my note was regarding this line:

The first one only has 16x16px favicon.ico, but the second one has nice 180x180 favicon.

Should we fallback to a company logo if we have a low resolution product logo?

In my opinion we shouldn't, but we can improve the algorithm by the comparison of subdomain's and domain's favicons and returning one with a better quality, if favicons are the same but with different resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants