-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve subdomain fallback #4
Comments
Subdomain may have completely different icon, I'm not sure it's a good idea to fallback to a domain's one. |
In this case we'd have icon of the company who made the product instead of an icon of the product. Anyway, fallback is not necessary here, so it's not a real case. |
You're right, but my note was regarding this line:
Should we fallback to a company logo if we have a low resolution product logo? In my opinion we shouldn't, but we can improve the algorithm by the comparison of subdomain's and domain's favicons and returning one with a better quality, if favicons are the same but with different resolution. |
See online.mbank.pl vs mbank.pl.
The first one only has 16x16px
favicon.ico
, but the second one has nice 180x180 favicon.The text was updated successfully, but these errors were encountered: