bug: Project structure is a mess

[cyberluke]

Where do you have dev guidelines?

Because of two level nested structure, I cannot import specific package:

"@logto/js": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/js",
"@logto/client": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/client",
"@logto/node": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/node",
"@logto/express": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/express",

Only @logto/express": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages works

How do you test it in some 3rd party integration package when developing?

[charIeszhao]

Hi, can you let us know what you are trying to do?

I don't quite get the "two level nested structure". The whole JS SDK repo is a "PNPM monorepo".
Refer to docs for more info: https://pnpm.io/workspaces

[charIeszhao]

If you want examples of integrating with 3rd party frameworks / libraries. You can check our sample projects.

For example:
https://github.com/logto-io/js/tree/master/packages/react-sample

All sample links can be found here:
https://github.com/logto-io/js/tree/master?tab=readme-ov-file#samples

[cyberluke]

    "@logto/js": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/js",
    "@logto/client": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/client",
    "@logto/node": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/node",
    "@logto/express": "git+https://github.com/logto-io/js.git#a0f91a3acf84c34eac6fa5b89348896a8ea2bfe4:packages/express",

I tried to reference it in my dev app package.json like this

pnpm can resolve subdirectory, but not nested subdirectories (packages is ok, but packages/js not)

I want to use your master branch with new features.

[cyberluke]

in your sample you reference it as workspace:

"dependencies": {
    "@logto/express": "workspace:^",
    "cookie-parser": "^1.4.6",
    "express": "^4.20.0",
    "express-session": "^1.17.3"
  }

but my workspace is different, actually I use bun not pnpm in my dev app

[cyberluke]

bun supports also workspaces: https://bun.sh/docs/install/workspaces

maybe I'm doing something wrong, I'm new to workspaces

(I tried cloning repo locally and reference it using file:/ but because you use workspace ref, it fails as well)

thank you

[cyberluke]

even I create bun-workspace.yml and reference your packages:

packages:
  - '/home/runner/workspace/logto/js/packages/js'
  - '/home/runner/workspace/logto/js/packages/client'
  - '/home/runner/workspace/logto/js/packages/node'
  - '/home/runner/workspace/logto/js/packages/express'

it fails with:

Workspace dependency "@logto/js" not found

Searched in "./logto/js/packages/client/^"

because you reference it using workspace:^

DeepSeek advices to rewrite your packages.json to not use ^ syntax

[cyberluke]

replacing workspace:^ with file:../js solved that, but it seems it is not possible to use your repo when testing/developing locally and integrating in 3rd party dev app by default

[charIeszhao]

OK, I see what you want to do. But our repo is not initially designed for users who want to use our master code. Since the master code may not be stable at times and may even include breaking changes sometimes, it's really not recommended to directly use it.

Is there any specific reason you want to use master code instead of published versions? We don't actually have any unpublished features at the moment, I believe. And you can always contact us if there's a feature in master code you want to use but not published yet.

Finally, if you still want to keep using our master code, the easiest way I can think of is to clone/fork the monorepo, and making your own testing/developing app as a subpackage in it. Then you can use pnpm and the workspace protocol, too. Is this an option for you to ditch bun and use pnpm instead?

[cyberluke]

I did not want to clone it initially, but there was some bug and I had to use the latest version. Asking AI assistant, it seemed that the structure of your repo does not allow using github as a dependency while other packages can do it. So in the end I had to clone the repo. It's not a big deal and you can close this issue. I just wanted to know if I did not miss something and if there is some other approach. I can tell you that if you start using Pytorch in Python + NVIDIA Cuda + Microsoft AI SDK + Intel AI tools + Huggingface transformers and diffusers - it is such a big mess and commercial american companies don't communicate while 50 people asking for some fix. So it is quite common to use bleeding edge master :D and often developer needs to fetch several libraries from some SDK and compile it in C++ because even Microsoft primarily focus on Linux and they don't support Windows (yet - like two years already) - which if funny. So I'm used to it and there is much more pain on the way, the worst thing is if you are perfectionist and you can get stuck several hours with small feature because it's the details that matters :D

…

On Wed, Jan 22, 2025 at 8:59 AM Charles Zhao ***@***.***> wrote: OK, I see what you want to do. But our repo is not initially designed for users who want to use our master code. Since the master code may not be stable at times and may even include breaking changes sometimes, it's really not recommended to directly use it. Is there any specific reason you want to use master code instead of published versions? We don't actually have any unpublished features at the moment, I believe. And you can always contact us if there's a feature in master code you want to use but not published yet. Finally, if you still want to keep using our master code, the easiest way I can think of is to clone/fork the monorepo, and making your own testing/developing app as a subpackage in it. Then you can use pnpm and the workspace protocol, too. Is this an option for you to ditch bun and use pnpm instead? — Reply to this email directly, view it on GitHub <#901 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIPKT5DSOL7QJ5BZCYXBG32L5FUVAVCNFSM6AAAAABUZB3C2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWGUZDSOJTGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>