Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mozextension page theming can break addons #43

Open
CharoSW opened this issue May 21, 2018 · 1 comment
Open

mozextension page theming can break addons #43

CharoSW opened this issue May 21, 2018 · 1 comment
Labels

Comments

@CharoSW
Copy link
Contributor

CharoSW commented May 21, 2018

I use a sidebar addon which can link into the new firefox theme api. Because the userContent part of firefox-gnome-theme sets the background color of mozextension pages statically that part of the extension breaks. So while this setting may be useful for mozextension pages that show in a normal tab it can have unintended side effects for those that show in the sidebar. Is there possibly a way to restrict the theming to just the normal tab pages

@lunakurame lunakurame added this to the Firefox 60 milestone Jun 5, 2018
@lunakurame lunakurame added the bug label Jun 5, 2018
@lunakurame
Copy link
Owner

I don't think there is a clear way to restrict theming just the settings page but not other pages since the extensions' file names seem to not be standarized, but we can try to hack our way around this problem with a regexp, similarly to how we handle extensions' popups:
@-moz-document regexp("^moz-extension://.+/popup.html$")

Can you give me a link to that extension you are talking about or its name, so I can test if it works with my regexp? I see uMatrix adds a panel to the sidebar too, its URL is moz-extension://<extension id>/logger-ui.html. And it's the same for uBlock.

@rafaelmardojai rafaelmardojai removed this from the Firefox 60 milestone Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants