Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP Configuration "Download Library" button fails on Magento 2.3.1 #3

Open
Hailong opened this issue May 24, 2019 · 9 comments
Open

Comments

@Hailong
Copy link

Hailong commented May 24, 2019

It fails when unzipping the downloaded GeoLite2-City.tar.gz because the phar wrapper is unregistered in the beginning of /app/bootstrap.php script. The code snippet is below:

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

/**
 * Environment initialization
 */
error_reporting(E_ALL);
stream_wrapper_unregister('phar');
#ini_set('display_errors', 1);
@loid345
Copy link

loid345 commented Jun 10, 2019

Can't download file. Please try again! RecursiveDirectoryIterator::__construct(): Unable to find the wrapper "phar" - did you forget to enable it when you configured PHP?

@Hailong
Copy link
Author

Hailong commented Jun 10, 2019

My current workaround for this issue is to use a package named Zippy, while a problem of this package is that we need to take its master branch at this moment, because its latest release branch doesn't work for me. Here is the code change for reference.

@Quintenps
Copy link

Also experiencing this on 2.2.8

@DrakeJack
Copy link

Please try to edit the unregister 'phar' to
#stream_wrapper_unregister('phar');
Then let's try to download the Geo IP library.

You can remove the # symbol after downloading successfully.

@Hailong
Copy link
Author

Hailong commented Jul 29, 2019

Hi @DrakeJack , since Magento had decide to unregister it in there code, I mean if we could fix it from the module code?

As I mentioned, I just tried Zippy, and it works fine for me.

@ArnoVDC
Copy link

ArnoVDC commented Sep 4, 2019

The latest version of Zippy didn't work for me. I just used shell_exec() to unzip the file. I know it's not a very good solution, but it works.

@raidoa
Copy link

raidoa commented Oct 7, 2019

You can tag 2.3.2 with the same issue.

@itsolon
Copy link

itsolon commented Oct 7, 2019

can confirm problem on 2.3.2 with 1.0.4

@rav-redchamps
Copy link

using below code

stream_wrapper_restore('phar');

just above line# 95 [$phar = new \PharData($path . '/GeoLite2-City.tar.gz');] of file Controller/Adminhtml/System/Config/Geoip.php will solve the problem.

I want to create pull request for this change but unfortunately, this module asks for 2 other modules Mageplaza_Core & Mageplaza_Backend to run and I couldn’t find those modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants