Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in CustomLayerHost render(parameters:mtlCommandBuffer:mtlRenderPassDescriptor) calls #513

Closed
Cal-um opened this issue Jun 30, 2021 · 3 comments
Labels
bug 🪲 Something is broken!

Comments

@Cal-um
Copy link

Cal-um commented Jun 30, 2021

Environment

  • Xcode version:12.5.1
  • iOS version:14.5
  • Devices affected: sims + device
  • Maps SDK Version: v10.0.0-rc.2

Observed behavior and steps to reproduce

CustomLayerHost Render delegate method is called continuously after double tap zooming.

  • Open CustomLayerExample.swift and breakpoint in the render method (e.g. line 105) or print something on this line.
  • Run and open custom layer example
  • drag map and observe render calls when dragging and stopping when dragging is finished.
  • now double tap to zoom and observe render calls never end after animation is finished.

Expected behavior

Im not sure what the expected behavior should be. Render calls 60ps or only when it needs to.

I discovered this trying to make a metal node animate and noticed it only works when after double tap zooming. Is there a way to control the frames to make it render continuously as it does when double tapping as above? e.g. control the render by a displayLink?

@Cal-um Cal-um added the bug 🪲 Something is broken! label Jun 30, 2021
@Cal-um Cal-um changed the title Inconsistencies in CustomLayerHost Render(parameters:mtlCommandBuffer:mtlRenderPassDescriptor) calls Inconsistencies in CustomLayerHost render(parameters:mtlCommandBuffer:mtlRenderPassDescriptor) calls Jun 30, 2021
@macdrevx
Copy link
Contributor

Possible duplicate of #469. @Cal-um we've just released v10.0.0-rc.3 — could you retest on that version?

@Cal-um
Copy link
Author

Cal-um commented Jul 1, 2021

Checked and all good now.

Do you know of way to control the number of renders when the map is idle? I need to control it to make animation work in the metal custom layer.

@Cal-um
Copy link
Author

Cal-um commented Jul 1, 2021

@macdrevx fwiw I found a solution and added a feature request #514

@macdrevx macdrevx closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something is broken!
Projects
None yet
Development

No branches or pull requests

2 participants