add new location widget #2555
Open
add new location widget #2555
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-low
requested changes
Feb 17, 2025
Comment on lines
13
to
16
| minWidth: 4, | ||
| defaultWidth: 4, | ||
| minHeight: 4, | ||
| defaultHeight: 4, |
There was a problem hiding this comment.
I think these can be tweaked:
minWidthshould be 2minHeightshould be 2 (this cuts off the Lon/Lat display but some people may not need that visible)defaultHeightshould be 3
I also think you should change TaskPane.jsx line 60 so that this widget's height in the default layout is 3
There was a problem hiding this comment.
I took a slightly different approach, apparently i had some variable names off, so the wrong widget was being displayed. I ended up changing the values in the location widget like you suggested, but i opted for increasing the height of the task map instead to match the height of the other widgets in the default layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2426