Implicit operator TValue allows comparison of two different ValueOf types.

[Paul-Williams]

Implicit operator back to TValue, added last year, allows for comparison of two different ValueOf object types.

Given :

class Something : ValueOf<string, Something> { }

class SomthingElse : ValueOf<string, SomthingElse> { }

...
void Test()
{
      var o1 = Something.From("test");
      var o2 = SomethingElse.From("test");
      var r = o1 == o2;
}

There is no compiler issue as there is an implicit convertion and the result 'r' will be true.
This may be by design, but it seems to do away with a lot of the potential safety which this class could provide.

If the implicit convertion is removed then the above comparison will create a compile-time error and so not be allowed.
I think that would be prefered.

[Paul-Williams]

Sorry, just realized that this is almost a complete duplicate of issue #9

[mcintyre321]

It does look like a problem. Can you please submit a PR and I'll do a major version bump

…

On Tue, 4 May 2021, 23:54 Paul Williams, ***@***.***> wrote: Reopened #14 <#14>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDJ6XKHHWYHZTAJMD3M6LTMB3JVANCNFSM44DSRF4A> .

[mattfrear]

Hi @mcintyre321 sorry for introducing something which had to be reverted. It seemed like a good idea at the time.

[mcintyre321]

no worries - it seemed like one to me too :D

…

On Fri, 11 Jun 2021 at 05:54, Matt Frear ***@***.***> wrote: Hi @mcintyre321 <https://github.com/mcintyre321> sorry for introducing something which had to be reverted. It seemed like a good idea at the time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDJ6T5SCNMACDP7GHBFVDTSGJGTANCNFSM44DSRF4A> .