Skip to content
This repository has been archived by the owner on Dec 9, 2021. It is now read-only.

Add redirect support to static build #264

Closed
dcgauld opened this issue Oct 1, 2019 · 3 comments · Fixed by #288
Closed

Add redirect support to static build #264

dcgauld opened this issue Oct 1, 2019 · 3 comments · Fixed by #288
Assignees
Labels
enhancement New feature or request

Comments

@dcgauld
Copy link
Contributor

dcgauld commented Oct 1, 2019

Currently, statically building the site and uploading to S3 doesn't honor redirects from Wagtail. wagtail-nest/wagtail-bakery#14 seems to cover adding support for this, but hasn't had much movement recently (although a custom solution has been suggested here).

It might be that the static build isn't around long enough for this to be worth doing.

https://docs.aws.amazon.com/AmazonS3/latest/dev/how-to-page-redirect.html

@dcgauld dcgauld added enhancement New feature or request question Further information is requested labels Oct 1, 2019
@stevejalim
Copy link
Contributor

Happy to take this on

@stevejalim stevejalim removed the question Further information is requested label Oct 1, 2019
@stevejalim
Copy link
Contributor

While we may not be using redirects yet, having them working and in our back pocket is definitely wortwhile. Thanks for raising @dcgauld!

@stevejalim stevejalim self-assigned this Oct 1, 2019
@stevejalim
Copy link
Contributor

It looks like django-bakery already supports this via BuildableRedirectView: https://github.com/datadesk/django-bakery/blob/a2f1f74b03951450d797ec70cc9872d6c694e1e3/bakery/views/base.py#L166

So it might be worth exploring how to leverage this, rather than write our own.

Even better if we can find a way to work it into wagtail-bakery

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants