Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load esmify for projects that don't use UMD #600

Open
talentlessguy opened this issue Jul 11, 2023 · 1 comment
Open

Don't load esmify for projects that don't use UMD #600

talentlessguy opened this issue Jul 11, 2023 · 1 comment

Comments

@talentlessguy
Copy link

esmify depends on a deprecated core-js module and also on babel-runtime. And it's only loaded if UMD is set as target output. I'd suggest marking esmify as an optional dependency, it's dynamically loaded already anyway.

@gqlts/cli 3.2.19-beta.88
└─┬ esmify 2.1.1
└─┬ babel-plugin-import-to-require 1.0.0
└─┬ babel-template 6.26.0
├─┬ babel-runtime 6.26.0
│ └── core-js 2.6.12
├─┬ babel-traverse 6.26.0
│ ├─┬ babel-messages 6.23.0
│ │ └─┬ babel-runtime 6.26.0
│ │   └── core-js 2.6.12
│ ├─┬ babel-runtime 6.26.0
│ │ └── core-js 2.6.12
│ └─┬ babel-types 6.26.0
│   └─┬ babel-runtime 6.26.0
│     └── core-js 2.6.12
└─┬ babel-types 6.26.0
└─┬ babel-runtime 6.26.0
└── core-js 
@talentlessguy talentlessguy changed the title Optionally load esmify for projects that don't use UMD Don't load esmify for projects that don't use UMD Jul 11, 2023
@meabed
Copy link
Owner

meabed commented Jul 11, 2023

Thanks @talentlessguy - will look into it.
I have tried esmify before but wasn't successful with it. I will get it another try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants