Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corr_fun function documentation and input requirements unclear #24

Open
moylettsinead opened this issue Dec 8, 2024 · 1 comment · May be fixed by #15
Open

corr_fun function documentation and input requirements unclear #24

moylettsinead opened this issue Dec 8, 2024 · 1 comment · May be fixed by #15
Assignees

Comments

@moylettsinead
Copy link

The corr_fun function appears to have unclear documentation regarding its input requirements. The function expects a data frame, but the intuitive usage would be to pass two vectors for correlation analysis.

Function requires parameters that aren't mentioned in the initial error message
Parameter 'nx' and 'ny' are required but not documented clearly
Input requirements are different to other correlation functions
Error messages don't guide users to correct usage

Update function documentation to clearly list all required parameters:
df: input data frame
nx: name of first variable
ny: name of second variable
method: correlation method
Add examples in documentation showing correct usage
Improve error messages to be more informative

@moylettsinead
Copy link
Author

@PHS-Meantrix PHS-Meantrix linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants