Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Refactor modals #49

Closed
CST1229 opened this issue Dec 13, 2022 · 3 comments · Fixed by #186
Closed

Refactor modals #49

CST1229 opened this issue Dec 13, 2022 · 3 comments · Fixed by #186
Labels
codebase issue An issue with the client's terrible codebase developer-facing An issue that's more related to developing enhancement New feature or request medium priority

Comments

@CST1229
Copy link
Member

CST1229 commented Dec 13, 2022

The current system of having a ton of imports in App.svelte is a mess, we should find another way (openModal() function and passing a component constructor into it?)

@CST1229 CST1229 added the developer-facing An issue that's more related to developing label Dec 13, 2022
@Bloctans Bloctans added enhancement New feature or request medium priority codebase issue An issue with the client's terrible codebase labels Dec 16, 2022
@Bloctans
Copy link
Member

The current system of having a ton of imports in App.svelte is a mess, we should find another way (openModal() function and passing a component constructor into it?)

ive made a tiny js file that allows for calling a single function instead of setting 2 stores
maybe we can start from there

@showierdata9978
Copy link
Member

showierdata9978 commented May 14, 2023

there are dynamic imports (:

@tnix100 tnix100 linked a pull request Oct 23, 2023 that will close this issue
@tnix100
Copy link
Member

tnix100 commented Oct 23, 2023

This has been fixed in the development build of 1.8. This issue will be closed upon 1.8 releasing.

@tnix100 tnix100 closed this as completed Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
codebase issue An issue with the client's terrible codebase developer-facing An issue that's more related to developing enhancement New feature or request medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants