Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Add Revower support #96

Closed
JoshAtticus opened this issue Feb 25, 2023 · 11 comments · Fixed by #102
Closed

Add Revower support #96

JoshAtticus opened this issue Feb 25, 2023 · 11 comments · Fixed by #102
Labels
enhancement New feature or request low priority

Comments

@JoshAtticus
Copy link
Member

Is your feature request related to a problem? Please describe.
Yes and no. The problem is that Revower is very spammy with no support because it is used so much, like Discord bridge used to.

Describe the solution you'd like
Adding support for Revower to Meower Svelte (with bridged tag)

Describe alternatives you've considered
Switching to Discord | Webhooks | Revower badges?

Additional context
None.

@JoshAtticus JoshAtticus added enhancement New feature or request low priority labels Feb 25, 2023
@PizzaPizza72
Copy link

I like this idea. 😄

@williamhorning
Copy link
Contributor

As I said in #94, we shouldn't support stuff like this if it's library/bot specific. If we want to provide better support for bridges, it should be done like the solution I described in https://github.com/meower-media-co/Meower-SvelteKit/issues/9

@showierdata9978
Copy link
Member

DO YOU NOT GET THIS IS SHORT TERM?

@williamhorning
Copy link
Contributor

@showierdata9978 I understand that, but we shouldn't need to implement stuff like this if it's supposed to be short term.

@JoshAtticus
Copy link
Member Author

Then why was Discord support added?

@JoshAtticus
Copy link
Member Author

CL4 just keeps getting delayed, this should be added. Ok fine if you don't want to work on it, but it's still a good idea.

@JoshAtticus
Copy link
Member Author

We were supposed to get CL4 by the end of January, we are in March now. I think it is safe to keep adding new things.

@williamhorning
Copy link
Contributor

@JoshAtticus Discord support was added as it was used way before the CL4 port was likely to be moved to prod. It's actually close to being released now so I see no reason to add short term patches like this when CL4 should hopefully be out by the end of the month. If it isn't by then, I guess we could implement it.

@JoshAtticus
Copy link
Member Author

End of the month is quite a long way away, I wouldn't call it "close", remember we just started March. Anyways you don't have to work on it, even when CL4 server comes out, CL4 client will also take time to make

@JoshAtticus
Copy link
Member Author

Update to stop Mike from marking as stale,

  • William refuses to see that he does not have to work on all issues because he doesn't own Meower nor even actively helps the development of any frontend projects,
  • CL4 keeps getting delayed so it is likely safe to keep adding features,
  • Revower support isn't currently in Meower Svelte and should be added to reduce spam

@Bloctans
Copy link
Member

ITS VERY EASY TO ADD THIS (i think)

@williamhorning williamhorning linked a pull request Mar 12, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants