Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from overriding our required arguments #355

Closed
FFY00 opened this issue Mar 21, 2023 · 1 comment · Fixed by #364
Closed

Prevent users from overriding our required arguments #355

FFY00 opened this issue Mar 21, 2023 · 1 comment · Fixed by #364
Labels
bug Something isn't working

Comments

@FFY00
Copy link
Member

FFY00 commented Mar 21, 2023

We pass several arguments to Meson calls, some of them are required, some of them are simply meant as defaults, which the user can override (see GH-329). We should pass the our defaults first, then the user arguments, and finally, the arguments we require to not be changed.

Supersedes GH-330

@dnicolodi
Copy link
Member

With #383 merged, there aren't anymore required arguments passed to Meson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants