-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13.0 release #372
Comments
I will edit the comment and title to reflect that this is about |
Yes, sorry, this is about 0.13.0. |
In general, what we want from a release is:
We'd like For this release, the regression related to MSVC that gh-371 fixes is a clear blocker, and we all agree on that. Furthermore, we need to update the docs for the main new feature (editable installs), that's gh-369. Basically everything else is nice to have I believe (also the build dir name for editable installs, that's a really minor thing when you take a step back, and would be completely fine to change in 0.14.0). Several bug fixes are close to the finish line and we'd like to include them, but if they miss 0.13.0 and we release them in 0.13.1 or 0.14.0 shortly after, that doesn't seem like the end of the world. We can release one of those within 1-2 weeks of 0.13.0, that would not be a problem. We don't want to turn into setuptools-style practices with 67 major release and a minor/bugfix release every week, but we're very far from that territory right now:) There's different things folks want to go into this release. It seems like there's no need to either mark those as must-have (unless they meet the "blocker due to regression, docs for feature, or It seems to me like @FFY00 and @dnicolodi both have multiple PRs open that they'd like to get merged. Which takes time and review, and updates if there's merge conflicts. But it seems to be more constructive to me to just let them progress at their own pace at this point, and only take priority decisions if really necessary. If you think that's the case, I suggest indicating that with "I think this is too risky or will block release" (this should be quite rare). At the moment I have no PRs open, and do have an interest in getting |
@FFY00 opened this issue because I proposed dropping #348 from the 0.13.0 release. I proposed that because @FFY00 comments on that and other PRs like #364 made it sound like there is some urgency in having a release out of the door very soon. It seems that we don't need to rush. Yet, I agree that having a new release soon with the improvements already merged in main is desirable. I agree with @rgommers I would be happy with releasing current main plus #371 and updated documentation as per #369. It would also be nice to find consensus on #370 and don't have to release 0.13.0 with a default editable build directory different from what will be used in 0.14.0. I think that a release with these issues covered could be safely be cut next week. I would leave #348 and #364 for 0.14.0 even as main focus. I think the two PR go together and a real fix for |
A regression with Meson 1.1.0 was just reported for This still seems okay, right @dnicolodi? You just opened gh-387 which is nice to take along. And then we may be good to go for 0.13.0? |
I think we want to update the documentation as per #369 before the release, too. I have a local branch where I started to work on it. If we want 0.13.0 out ASAP, I would at least like to get the main points about editable installs right before. |
Just to avoid duplicate work: I've already started to prepare the release notes for 0.13.0. I meant to finish today and send a PR, but real work got in the way. |
Great, thanks for that - both for working on it and the heads up (I hadn't started, but did think about it). |
So docs left only at this point it seems - that's progress:) |
Okay, let's call the current state of |
Continuing the conversation from #348.
I think, for the new release, #370 and #371 must be sorted out.
When I talked with @rgommers, we decided #348 should also go into the release, that's why I marked it as a release blocker. Unlike the other two issues mentioned above, it doesn't necessarily need to go into 0.13.0, so since this has been brought up in #348 (comment), I am opening this issue to discuss it.
The text was updated successfully, but these errors were encountered: