From a70f3199788f1b656c069cee091adf5e05b415d3 Mon Sep 17 00:00:00 2001
From: Ricky Pritchett <ricky@Rickys-Air.lan>
Date: Sat, 7 Sep 2024 18:29:02 -0400
Subject: [PATCH 1/2] Environment Overrides and README updates

---
 .gitignore   |  2 +-
 README.md    | 22 +++++++++++++++++++++-
 Taskfile.yml |  2 +-
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 489ba74..fe220d7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -164,4 +164,4 @@ cython_debug/
 *.tar.gz
 .task
 models
-task.env
\ No newline at end of file
+*.env
\ No newline at end of file
diff --git a/README.md b/README.md
index c75bf7a..7e5b209 100644
--- a/README.md
+++ b/README.md
@@ -51,7 +51,7 @@ Running tasks is orchestrated by using [Taskfile.dev](https://taskfile.dev/)
 
 This document provides instructions on how to run tasks defined in the `Taskfile.yml`.  
 
-Create a task.env at the root of project to define enviroment overrides. 
+Create a `.env` at the root of project to define enviroment overrides. 
 
 ## Tasks Overview
 
@@ -117,3 +117,23 @@ task triton-start
 # Tail logs of running containr
 docker logs -f $(docker ps -q --filter "name=triton-inference-server")
 ```
+
+### `Overriding Defaults`  
+
+At Root of project define file *local.env* 
+
+### Environment Variables for `local.env`
+
+The following docker compose and Task variables can be overridden in the `local.env` file:
+
+| Variable Name     | Description                                                      | Default Value                   |
+|-------------------|------------------------------------------------------------------|---------------------------------|
+| `TRITON_INFERENCE_SERVER_IMAGE`    | TRITON BASE IMAGE                               | `nvcr.io/nvidia/tritonserver`   |
+| `TRITON_INFERENCE_SERVER_TAG`      | TRITON BASE IMAGE VERSION                       | `24.07-py3`                     |
+| `MODEL_REPOSITORY_SOURCE`          | SOURCE MODEL REPO DIR                           | `./model-repository`            |
+| `MODEL_REPOSITORY_TARGET`          | TARGET MODEL REPO DIR                           | `/model-repository`             |
+| `HF_HUB_CACHE_SOURCE`              | SOURCE HUGGING FACE CACHE DIR                   | `./models`                      |
+| `HF_HUB_CACHE_TARGET`              | TARGET HUGGING FACE CACHE DIR                   | `/models`                       |
+| `COMPOSE_CONDA_PACK_BASE_IMAGE`    | COMPOSE CONDA PACK BASE IMAGE                   | `continuumio/miniconda3:latest` |
+
+**Note:** Format in `local.env` file is as following `VAR`=`VALUE`.
diff --git a/Taskfile.yml b/Taskfile.yml
index 5226bf8..cba5bda 100644
--- a/Taskfile.yml
+++ b/Taskfile.yml
@@ -1,6 +1,6 @@
 version: '3'
 
-dontenv: ['task.env']
+dontenv: ['.env']
 
 vars:
   COMPUTE_TYPE: '{{default "gpu" .COMPUTE_TYPE}}'

From a21e5afe06f547b634f9602a842db3f4ec86ab61 Mon Sep 17 00:00:00 2001
From: Ricky Pritchett <ricky@Rickys-Air.lan>
Date: Sat, 7 Sep 2024 18:34:30 -0400
Subject: [PATCH 2/2] Updated name of environment file

---
 README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 7e5b209..e72c406 100644
--- a/README.md
+++ b/README.md
@@ -120,9 +120,9 @@ docker logs -f $(docker ps -q --filter "name=triton-inference-server")
 
 ### `Overriding Defaults`  
 
-At Root of project define file *local.env* 
+At Root of project create file **.env** 
 
-### Environment Variables for `local.env`
+### Environment Variables for `.env`
 
 The following docker compose and Task variables can be overridden in the `local.env` file:
 
@@ -136,4 +136,4 @@ The following docker compose and Task variables can be overridden in the `local.
 | `HF_HUB_CACHE_TARGET`              | TARGET HUGGING FACE CACHE DIR                   | `/models`                       |
 | `COMPOSE_CONDA_PACK_BASE_IMAGE`    | COMPOSE CONDA PACK BASE IMAGE                   | `continuumio/miniconda3:latest` |
 
-**Note:** Format in `local.env` file is as following `VAR`=`VALUE`.
+**Note:** Format in `.env` file is as following `VAR`=`VALUE`.