Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default CMD to v2 in Dockerfiles if no command is set #510

Open
stevapple opened this issue Jan 6, 2025 · 1 comment
Open

Set default CMD to v2 in Dockerfiles if no command is set #510

stevapple opened this issue Jan 6, 2025 · 1 comment

Comments

@stevapple
Copy link

Feature request

Add a CMD ["v2"] line to Dockerfiles to provide a default command for serving with Docker.

Motivation

Now that the v2 CLI is the recommended and documented way to use infinity, and it fully supports configuration via environment variables, defaulting the CMD to v2 can allow starting the container with no arguments but environment variables.

Your contribution

I can submit a PR if agreements can be reached.

@michaelfeil
Copy link
Owner

@stevapple I just removed the default to v1. Such changes are hard to revert / change your mind about. If this issue becomes popular, I might consider it.

@michaelfeil michaelfeil changed the title Set default CMD to v2 in Dockerfiles Set default CMD to v2 in Dockerfiles if no command is set Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants