Version check step #524
Version check step #524
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a version check step to the PyPI release workflow to ensure version consistency between packages before deployment.
- Added version comparison step in
.github/workflows/pypi_release.yamlthat extracts and validates matching versions from bothinfinity_clientandinfinity_embpyproject.toml files - Fails the workflow early if versions don't match to prevent inconsistent package releases
- Provides clear error messaging showing the mismatched versions for debugging
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
.github/workflows/pypi_release.yaml
Outdated
| version1=$(grep 'version = ' "$file1" | sed 's/version = //' | tr -d '\"') | ||
| version2=$(grep 'version = ' "$file2" | sed 's/version = //' | tr -d '\"') |
There was a problem hiding this comment.
logic: The grep pattern is fragile and may fail if there are comments containing 'version = ' or if the version field spans multiple lines. Consider using a TOML parser instead.
.github/workflows/pypi_release.yaml
Outdated
| if [ "$version1" != "$version2" ]; then | ||
| echo "Version mismatch: $version1 != $version2" | ||
| exit 1 | ||
| else |
There was a problem hiding this comment.
logic: Version comparison should handle cases where version strings are empty or malformed. Add validation before comparison.
| if [ "$version1" != "$version2" ]; then | |
| echo "Version mismatch: $version1 != $version2" | |
| exit 1 | |
| else | |
| if [ -z "$version1" ] || [ -z "$version2" ]; then | |
| echo "Error: Empty version string detected" | |
| exit 1 | |
| elif [ "$version1" != "$version2" ]; then | |
| echo "Version mismatch: $version1 != $version2" | |
| exit 1 | |
| else |
.github/workflows/pypi_release.yaml
Outdated
| working-directory: ${{ github.workspace }} | ||
| run: | |
There was a problem hiding this comment.
style: Setting working-directory to github.workspace is redundant since the paths are already absolute. This can be removed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 79.86% 79.86%
=======================================
Files 43 43
Lines 3486 3486
=======================================
Hits 2784 2784
Misses 702 702 ☔ View full report in Codecov by Sentry. |
|
Makes sense, but was internationally not bumping infinity_client. Perhaps a ci that would auto generate the client would be better. |
|
That makes sense. And the package version of the generated client should match what the openapi description reports in the version field? |
|
I created a initial version of it, the idea is with changes to main the client will be regenerated and if there are changes a PR will be opened. |
Related Issue
closes #521
Checklist
Additional Notes
Added step to release pipeline to error out if the versions do not match.