From dd9ca703622ad42963b0bc20241ade98a5eaa847 Mon Sep 17 00:00:00 2001
From: Timothy Mothra <tilee@microsoft.com>
Date: Tue, 18 Feb 2025 15:13:57 -0800
Subject: [PATCH] fix compiler issue re: `Reverse()` method in Test project.
 (#2958)

* investigating

* reintroduce Reverse

* pr feedback
---
 .../QuickPulseTelemetryProcessorTests.cs      | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs b/WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
index 5a0a975676..aad7083ee1 100644
--- a/WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
+++ b/WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
@@ -643,7 +643,7 @@ public void QuickPulseTelemetryProcessorCollectsFullTelemetryItemsAndDistributes
             telemetryProcessor.Process(trace);
 
             // ASSERT
-            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
+            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Reverse().ToArray();
 
             var expectedProperties =
                 new Dictionary<string, string>()
@@ -766,7 +766,7 @@ public void QuickPulseTelemetryProcessorHandlesRequestSuccessSpecialCaseCorrectl
 
             // ASSERT
             // even though Success is set to false, since ResponseCode is empty the special case logic must have turned it into true
-            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray().Single();
+            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Single();
             double metricValue = accumulatorManager.CurrentDataAccumulator.CollectionConfigurationAccumulator.MetricAccumulators["Metric1"].CalculateAggregation(out long count);
 
             Assert.AreEqual(1, count);
@@ -822,7 +822,7 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTelemetryItemsIfTypeIs
             telemetryProcessor.Process(dependency);
             
             // ASSERT
-            Assert.AreEqual(TelemetryDocumentType.RemoteDependency.ToString(), accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray().Single().DocumentType);
+            Assert.AreEqual(TelemetryDocumentType.RemoteDependency.ToString(), accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Single().DocumentType);
         }
 
         [TestMethod]
@@ -911,16 +911,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullRequestTelemetryItemsO
             var collectedTelemetryStreamAll =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
                     .ToArray()
-                    .Reverse()
                     .Cast<RequestTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             var collectedTelemetryStreamSuccessOnly =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
                     document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
                     .ToArray()
-                    .Reverse()
                     .Cast<RequestTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             // the quota is 3 initially, then 0.5 every second (but not more than 30)
@@ -1038,16 +1038,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullDependencyTelemetryIte
             var collectedTelemetryStreamAll =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
                     .ToArray()
-                    .Reverse()
                     .Cast<DependencyTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             var collectedTelemetryStreamSuccessOnly =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
                     document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
                     .ToArray()
-                    .Reverse()
                     .Cast<DependencyTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             // the quota is 3 initially, then 0.5 every second (but not more than 30)
@@ -1166,16 +1166,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullExceptionTelemetryItem
             var collectedTelemetryStreamAll =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
                     .ToArray()
-                    .Reverse()
                     .Cast<ExceptionTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             var collectedTelemetryStreamSuccessOnly =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
                     document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
                     .ToArray()
-                    .Reverse()
                     .Cast<ExceptionTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             // the quota is 3 initially, then 0.5 every second (but not more than 30)
@@ -1292,13 +1292,13 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullEventTelemetryItemsOnc
             var collectedTelemetryStreamAll =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
                     .ToArray()
-                    .Reverse()
                     .Cast<EventTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             var collectedTelemetryStreamSuccessOnly =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
-                    document => document.DocumentStreamIds.Contains("StreamSuccessOnly")).ToArray().Reverse().Cast<EventTelemetryDocument>().ToArray();
+                    document => document.DocumentStreamIds.Contains("StreamSuccessOnly")).ToArray().Cast<EventTelemetryDocument>().Reverse().ToArray();
 
             // the quota is 3 initially, then 0.5 every second (but not more than 30)
 
@@ -1413,16 +1413,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTraceTelemetryItemsOnc
             var collectedTelemetryStreamAll =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
                     .ToArray()
-                    .Reverse()
                     .Cast<TraceTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             var collectedTelemetryStreamSuccessOnly =
                 accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
                     document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
                     .ToArray()
-                    .Reverse()
                     .Cast<TraceTelemetryDocument>()
+                    .Reverse()
                     .ToArray();
 
             // the quota is 3 initially, then 0.5 every second (but not more than 30)
@@ -1520,8 +1520,8 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTelemetryItemsOnceGlob
                 var collectedTelemetryForStream =
                     accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains(streamId))
                         .ToArray()
-                        .Reverse()
                         .Cast<RequestTelemetryDocument>()
+                        .Reverse()
                         .ToArray();
 
                 Assert.AreEqual(maxGlobalTelemetryQuota, collectedTelemetryForStream.Length);
@@ -3154,7 +3154,7 @@ public void VerifyBehaviorWhenDeferredIsTrue()
             // ASSERT
             Assert.IsFalse(accumulatorManager.CurrentDataAccumulator.GlobalDocumentQuotaReached);
             Assert.AreEqual(1, accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Count);
-            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
+            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray();
 
             Assert.AreEqual(TelemetryDocumentType.Request, Enum.Parse(typeof(TelemetryDocumentType), collectedTelemetry[0].DocumentType));
             var requestTelemetryDocument = (RequestTelemetryDocument)collectedTelemetry[0];
@@ -3198,7 +3198,7 @@ public void VerifyBehaviorWhenDeferredIsFalse()
             // ASSERT
             Assert.IsFalse(accumulatorManager.CurrentDataAccumulator.GlobalDocumentQuotaReached);
             Assert.AreEqual(1, accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Count);
-            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
+            var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray();
 
             Assert.AreEqual(TelemetryDocumentType.Request, Enum.Parse(typeof(TelemetryDocumentType), collectedTelemetry[0].DocumentType));
             var requestTelemetryDocument = (RequestTelemetryDocument)collectedTelemetry[0];