Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevSkim Action Failing Due to .NET Version Mismatch #30

Closed
Light-Leo opened this issue Jan 31, 2025 · 4 comments
Closed

DevSkim Action Failing Due to .NET Version Mismatch #30

Light-Leo opened this issue Jan 31, 2025 · 4 comments

Comments

@Light-Leo
Copy link

Description:

The DevSkim-Action GitHub Action has started failing unexpectedly in our workflows due to a .NET version mismatch in the Docker build process. The action has not been updated in 10+ months, but something seems to have changed, causing a breaking issue.

Steps to Reproduce:

  • Use the latest DevSkim-Action in a GitHub Actions workflow.
  • The action attempts to build its Docker image using .NET SDK 7.0.
  • The build fails when trying to install Microsoft.CST.DevSkim.CLI, as the latest version (1.0.52) only supports .NET 8.0+.

Observed Behavior:

The following error occurs during the Docker build:

error NU1202: Package Microsoft.CST.DevSkim.CLI 1.0.52 is not compatible with net7.0 (.NETCoreApp,Version=v7.0) / any.
Package Microsoft.CST.DevSkim.CLI 1.0.52 supports:
  - net8.0 (.NETCoreApp,Version=v8.0) / any
  - net9.0 (.NETCoreApp,Version=v9.0) / any

Can this action be updated to support .NET 8.0+, or is there a recommended workaround from the maintainers?

Thanks!

@joschi
Copy link

joschi commented Jan 31, 2025

Probably caused by microsoft/DevSkim#678.

Interesting doing such a breaking change in a patch release. 🙈

@gfs
Copy link
Contributor

gfs commented Jan 31, 2025

Doh, thanks, I'll get that fixed ASAP. #31

@gfs
Copy link
Contributor

gfs commented Jan 31, 2025

Probably caused by microsoft/DevSkim#678.

Interesting doing such a breaking change in a patch release. 🙈

That's a fair point, and sorry for the inconvenience. I didn't take into account the impact of the framework change to the Action which always pulls the latest DevSkim.

This was considered a patch level release of DevSkim because it has no breaking functionality changes for the program itself, but the framework migration could be considered a breaking change (and was in this case for the action). I'll try to keep that in mind for migrating to .NET 10 this November.

@gfs
Copy link
Contributor

gfs commented Jan 31, 2025

Should be resolved now, again sorry for the inconvenience, I'll try to have a better experience for future framework migrations.

@gfs gfs closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants