Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Missing ";" in email list in "Environment provisioning failed" action in "Env Request | Create Approved Environment" #9333

Open
1 task done
AdomasGaldikas opened this issue Nov 27, 2024 · 5 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@AdomasGaldikas
Copy link

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Flow fails at "Environment provisioning failed" action.
When there are more than one admin, the emails are not being separated with ";".
In the "Apply to each - Grant access to System Admins" loop in "Append to string variable" admin emails are being added without ";".

Image
Image

Solution: Center of Excellence - Core Components
Version: 4.45

Flow: Env Request | Create Approved Environment
Action: Environment provisioning failed

Action input body:

"body": {
        "email": "[email protected];[email protected]@company.com",
        "text": "ECR-01001 - CoE Starter Kit - Environment Request: There was an issue processing an Environment Creation Request",
        "text_1": "<h2>Notice: There was a problem provisioning the Environment.</h2><p>The approved Environment Creation Request was not completed, and the record has been closed. Please evaluate the error message and review the issue in the flow run history, then re-submit the request.</p><br>\n<span style=\"color: rgb(184,49,47)\">Error: </span><span style=\"color: rgb(184,49,47)\">An error occured when provisioning the approved environment.</span><span style=\"color: rgb(184,49,47)\"></span><br>\n</p>",
        "email_1": "",
        "email_2": "",
        "email_3": "",
        "text_2": ""
    }

Error:

{
  "error": {
    "code": "TriggerInputSchemaMismatch",
    "message": "The input body for trigger 'manual' of type 'Request' did not match its schema definition. Error details: 'String '[email protected];[email protected]@company.com' does not validate against format 'email'.'."
  }
}

Expected Behavior

No response

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.45

What app or flow are you having the issue with?

Env Request | Create Approved Environment

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

No response

Anything else?

No response

@AdomasGaldikas AdomasGaldikas added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Nov 27, 2024
@Jenefer-Monroe
Copy link
Collaborator

Hello. I do not repro this. And I do not have that action in my flow.

Can you please check to see if you have unmanaged layers on the flow?

@AdomasGaldikas
Copy link
Author

I do not have unmanaged layer.

Environment provisioning failed action is inside "Scope - Environment provisionig faide" scope.
This scope runs if the main scope "Scope - Provision environment" fails.
In my case it failed because of issue #9332.

Image

Also varEnvAdminEmails variable should have at least two emails for this bug to happen.

@Jenefer-Monroe
Copy link
Collaborator

oh I see. I was looking at the wrong place in the flow.

Is the fix as simple as adding the semicolon here?
Image

@Jenefer-Monroe
Copy link
Collaborator

Hello were you able to test the above? If it works I can fix for an upcoming release.

@Jenefer-Monroe
Copy link
Collaborator

I went ahead and made that change, hopefully that resolves.

@Jenefer-Monroe Jenefer-Monroe moved this to Code complete ☑ in CoE Starter Kit Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Code complete
Development

No branches or pull requests

2 participants