Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codegen): include framePath in jsonl format #34310

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat(codegen): include framePath in jsonl format #34310

merged 1 commit into from
Jan 14, 2025

Conversation

ruifigueira
Copy link
Contributor

Fixes: #34157

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ruifigueira ruifigueira changed the title feat(codegen): include framepPath in jsonl format feat(codegen): include framePath in jsonl format Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › tests/reporter-html.spec.ts:2651:5 › merged › execSync doesnt produce a second stdout attachment @macos-latest-node18-2

11 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1
⚠️ [installation tests] › tests/playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://cdn.playwright.dev) @package-installations-macos-latest
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:102:5 › selector generator › should not escape text with >> @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:112:5 › selector generator › should escape text with slash @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1453:1 › should not record route actions @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:91:3 › should throw if a directory and files are passed @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37575 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 9a9d22a into microsoft:main Jan 14, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: JSONL codegen doesn't include framepath
3 participants
@ruifigueira @pavelfeldman @yury-s