fix: limit decorations to prevent editor slowdown #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be a known problem: microsoft/vscode#202154 |
dgozman
approved these changes
Jan 10, 2025
| @@ -687,6 +687,9 @@ export class Extension implements RunHooks { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| if (completedDecorations.length > 1000) // too many decorations slow down the editor | |||
There was a problem hiding this comment.
Perhaps a 100? I can't imagine anyone reading more than five :)
There was a problem hiding this comment.
This limit is per-file, so 100 will be used up quickly. And we don't know which ones the user wants to read. So i'd stay high enough that we only prevent the performance bottleneck, and nothing else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/playwright#34248
Updating decorations slows down the editor when the number of decorations is too high. We can work around it by limiting the number of decorations.