Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-device-info does not seem to handle new architecture for windows #14341

Open
mikehardy opened this issue Feb 5, 2025 · 1 comment
Assignees
Labels
enhancement Extensions Tracks issues against community modules and extensions External Issue tracked in this repo but change will need to happen in another repo New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone

Comments

@mikehardy
Copy link

Problem Description

A friendly Microsoft person mentioned in react-native-permissions (zoontek/react-native-permissions#925) that they may be able to help with react-ntive-windows implementations of some important modules

Historically there was help from Microsoft getting react-native-device-info working, and I'll admit (as maintainer) I need the help for New Arch as well - related issue: react-native-device-info/react-native-device-info#1687

Steps To Reproduce

  1. Install react-native-windows 0.76+ with new arch enabled
  2. add react-native-device-info
  3. Sad developer 😆

I am deliberately being pretty brief about reproduction details because I believe it's trivial to reproduce, but I'm the maintainer - I expect to collaborate on the related issue

I will also apologize in advance for the very very out of date example app in repo, haven't had time to fix it

Expected Results

Working compile

CLI version

15 reproduces it

Environment

npx @react-native-community/cli info

Everything current as of this typing will reproduce - that's 0.77.0 and current version of react-native-device-info

Community Modules

react-native-device-info

Target Platform Version

None

Target Device(s)

Desktop

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

@mikehardy mikehardy added the bug label Feb 5, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 5, 2025
@Yajur-Grover Yajur-Grover self-assigned this Feb 6, 2025
@Yajur-Grover
Copy link
Contributor

Hey Mike! Thanks for filing this - I have been working on adding New Arch support for other community modules, and can work on adding New Arch support for react-native-device-info. We only have new arch support for more recent versions of RNW - the first step would be to upgrade ideally to a version >= 76. It looks like the module is currently on 0.67 - is this something that can be upgraded fairly smoothly?

@chrisglein chrisglein added Extensions Tracks issues against community modules and extensions External Issue tracked in this repo but change will need to happen in another repo New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric labels Feb 10, 2025
@chrisglein chrisglein added this to the Next milestone Feb 10, 2025
@chrisglein chrisglein added enhancement and removed bug Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Feb 10, 2025
@chrisglein chrisglein modified the milestones: Next, Backlog Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extensions Tracks issues against community modules and extensions External Issue tracked in this repo but change will need to happen in another repo New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
None yet
Development

No branches or pull requests

3 participants