Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of vcpkg-tool install #29857

Closed
clemenswasser opened this issue Feb 25, 2023 · 3 comments
Closed

Improve performance of vcpkg-tool install #29857

clemenswasser opened this issue Feb 25, 2023 · 3 comments
Assignees
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed Stale

Comments

@clemenswasser
Copy link
Contributor


Is your feature request related to a problem? Please describe.
When setting CMAKE_TOOLCHAIN_PATH to scripts/buildsystems/vcpkg.cmake and using manifest-mode, the vcpkg install command gets run for every CMake rerun. Even if all packages are already installed, this step takes 1.7s on my machine, which is a major delay when working on your Project's CMake Build system with an IDE that re-runs CMake on every edit (e. g. Visual Studio).
Where the time is currently being spent:

PowerShellCoreProvider::get_version 263.1 ms
cmd_execute_and_capture_environment (Executing vcvarsall.bat) 669.5 ms
cmd_execute_and_stream_lines (Executing cmake to detect the compiler) 606.2 ms

Proposed solution
Please either get rid of some steps in vcpkg install or make them faster.
For example, when using vcpkg.cmake we could avoid having to detect the compiler again in vcpkg install.
I have already tried to use GetFileVersionInfoW to detect the PowerShell Core version, but got into some trouble with the fake "app execution alias"/symlink in C:\Users\%USERNAME%\AppData\Local\Microsoft\WindowsApps\

Describe alternatives you've considered

Additional context

@Neumann-A
Copy link
Contributor

That is microsoft/vcpkg-tool#362

@Neumann-A
Copy link
Contributor

also duplicate of #14025

@Adela0814 Adela0814 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Feb 27, 2023
@github-actions
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Aug 31, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed Stale
Projects
None yet
Development

No branches or pull requests

4 participants