Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzers assembly needs to increment version in every NuGet package #204

Open
KirillOsenkov opened this issue Apr 22, 2021 · 0 comments · Fixed by #205
Open

Analyzers assembly needs to increment version in every NuGet package #204

KirillOsenkov opened this issue Apr 22, 2021 · 0 comments · Fixed by #205
Assignees
@AArnott
Labels
analyzers bug

Comments

@KirillOsenkov
Copy link
Member

The VSMac build started getting a message from Roslyn:

CompilerServer: server failed - server rejected the request due to analyzer / generator issues 'analyzer assembly '/Users/kirill/.nuget/packages/microsoft.visualstudio.composition.analyzers/16.9.13/analyzers/dotnet/Microsoft.VisualStudio.Composition.Analyzers.dll' has MVID '3edb20be-00d4-43c3-a073-2a0c7dd2b274' but loaded assembly 'Microsoft.VisualStudio.Composition.Analyzers, Version=16.9.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' has MVID 'de5014dd-66c4-4da2-8f04-b8bd915cba5b''

It turns out different projects in our build use two versions of the MS.VS.Composition package: 16.9.6-alpha and 16.9.13.

We can unify the versions, but @sharwell points out that the analyzer is authored incorrectly:

There is an authoring problem with the analyzer. The two different versions failed to use two different strong names (every package build for an analyzer needs to update the version number).
@AArnott AArnott self-assigned this Apr 26, 2021
@AArnott AArnott mentioned this issue Apr 26, 2021
Merged
@AArnott AArnott linked a pull request Apr 26, 2021 that will close this issue
Build unique assembly versions for every commit for the analyzers #205
Merged
AArnott added a commit to AArnott/vs-mef that referenced this issue Jun 12, 2023
@dependabot @AArnott
Bump CSharpIsNullAnalyzer from 0.1.329 to 0.1.495 (microsoft#204)
4f2a6d8 
* Crank up dependabot

* Bump CSharpIsNullAnalyzer from 0.1.329 to 0.1.495

Bumps [CSharpIsNullAnalyzer](https://github.com/AArnott/CSharpIsNull) from 0.1.329 to 0.1.495.
- [Release notes](https://github.com/AArnott/CSharpIsNull/releases)
- [Commits](https://github.com/AArnott/CSharpIsNull/commits)

---
updated-dependencies:
- dependency-name: CSharpIsNullAnalyzer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andrew Arnott <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this issue Jun 12, 2023
Merged
@Tornhoof Tornhoof mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
analyzers bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build unique assembly versions for every commit for the analyzers AArnott/vs-mef
2 participants
@AArnott @KirillOsenkov